On Mon, 6 May 2019 05:49:40 +0200 Thomas Huth <th...@redhat.com> wrote:
> On 05/05/2019 20.32, Greg Kurz wrote: > > Hi Thomas, > > > > Thanks for the janitoring :) > > > > On Sun, 5 May 2019 16:45:27 +0200 > > Thomas Huth <th...@redhat.com> wrote: > > > >> ... and remove the square brackets from "path" and "security_model", > >> since these parameters are not optional. > >> > > > > Well this is only true when fsdriver == local, but the other fs drivers, > > ie. proxy and synth, don't need it at all. > > Ok, then this is wrong in the output of "--help" instead. > Yeah, I've taken a look and both the usage and the man page need fixing... > > Each driver has its own set of > > options actually. This should better be described with separate lines IMHO. > > > > Also, it should be stated that "id" relates to the fs backend, ie. it > > belongs to the -fsdev "id" space, not to the device that gets exposed > > to the guest. > > Hmm, maybe it would be better if you do this patch, since you've > definitely got way more knowledge here than I do... Otherwise, I can > have a try, but it might take a while till I get back to this... > Sure, I'll do that. > Thomas Cheers, -- Greg
