On 08/05/2019 20.23, Eduardo Habkost wrote: > The oldest python3 version in distros that will be supported by > QEMU 4.1 is 3.5.3 (the one in Debian Stretch). Error out if > running python3 < 3.5. > > We have a .travis.yml job configured to use Python 3.4. Change > it to use Python 3.5. > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > configure | 5 +++-- > .travis.yml | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index 6b3ed8c532..520c207d66 100755 > --- a/configure > +++ b/configure > @@ -1841,8 +1841,9 @@ fi > > # Note that if the Python conditional here evaluates True we will exit > # with status 1 which is a shell 'false' value. > -if ! $python -c 'import sys; sys.exit(sys.version_info < (2,7))'; then > - error_exit "Cannot use '$python', Python 2 >= 2.7 or Python 3 is > required." \ > +if ! $python -c 'import sys; sys.exit(sys.version_info < (2,7) or \ > + (3,0) <= sys.version_info < (3,5))'; > then > + error_exit "Cannot use '$python', Python 2 >= 2.7 or Python 3 >= 3.5 is > required." \
Nit: There won't be a Python2 > 2.7 anymore, so you could also replace "2 >= 2.7" with "2.7" here. But well, it will go away next year anyway, so: Reviewed-by: Thomas Huth <th...@redhat.com>
