On Fri, 10 May 2019 at 08:52, Thomas Huth <th...@redhat.com> wrote: > > On 09/05/2019 18.54, Peter Maydell wrote: > > Further, if I "touch hw/i386/Kconfig" and then run make, nothing > > is rebuilt at all, so something seems to be wrong with our > > makefile dependencies somewhere. > > Now that's a good hint. There is definitely something wrong with the > dependencies here. I can see that I've got a file called > "x86_64-softmmu-config.devices.mak.d" in my build directory, but > apparently the Makefile tries to include > x86_64-softmmu/config-devices.mak.d via the SUBDIR_DEVICES_MAK_DEP > variable instead. Since that file does not exist, the dependencies are > completely ignored... Paolo, what was the intention here? Should the > dependencies always be generated in the *softmmu folders instead?
I think the .mak.d files should live in the foo-softmmu/ subdirectories, because that puts them next to the .mak files that they're the dependencies for (it also avoids the slightly aesthetically unpleasing very long filenames in the root of the build directory). thanks -- PMM
