> On May 11, 2019, at 2:05 PM, Thomas Huth <th...@redhat.com> wrote: > > On 11/05/2019 19.21, Programmingkid wrote: >> >>> On Apr 20, 2019, at 6:40 AM, Thomas Huth <th...@redhat.com> wrote: >>> >>> On 19/04/2019 15.44, G 3 wrote: >>>> >>>> On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: >>>> >>>>> On 19/04/2019 00.47, John Arbuckle wrote: >>>>>> Capstone is not necessary in order to use QEMU. Disable it by default. >>>>>> This will save the user the pain of having to figure why QEMU isn't >>>>>> building when this library is missing. >>>>>> >>>>>> Signed-off-by: John Arbuckle <programmingk...@gmail.com> >>>>>> --- >>>>>> configure | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/configure b/configure >>>>>> index 1c563a7027..77d7967f92 100755 >>>>>> --- a/configure >>>>>> +++ b/configure >>>>>> @@ -433,7 +433,7 @@ opengl_dmabuf="no" >>>>>> cpuid_h="no" >>>>>> avx2_opt="" >>>>>> zlib="yes" >>>>>> -capstone="" >>>>>> +capstone="no" >>>>>> lzo="" >>>>>> snappy="" >>>>>> bzip2="" >>>>> >>>>> AFAIK we ship capstone as a submodule, so how can this be missing? Also, >>>>> our philosophy is to keep everything enabled by default if possible, so >>>>> that the code paths don't bitrot. Thus I don't think that disabling this >>>>> by default is a good idea. ... so if you've got a problem here, there >>>>> must be another solution (e.g. is the system capstone detection not >>>>> working right on your system?). >>>>> >>>>> Thomas >>>> >>>> Thank you for replying. Capstone comes with QEMU? Every time I try to >>>> compile QEMU I see an error relating to Capstone not being on my system. >>>> Why do you feel that disabling Capstone by default is not a good idea? >>>> >>>> Here is the error message I see when compiling QEMU: >>>> >>>> CHK version_gen.h >>>> make[1]: *** No rule to make target >>>> `/Users/John/qemu-git/capstone/libcapstone.a'. Stop. >>>> make: *** [subdir-capstone] Error 2 >>> >>> I assume you're using a git checkout here, right? For git checkouts, the >>> Makefile should take care of calling the scripts/git-submodule.sh script >>> which should initialize the submodule in the capstone directory. >>> >>> What's the content of your .git-submodule-status file? What does >>> "configure" say about capstone support on your system? >>> >>> Thomas >> >> Yes I use a git checkout. >> >> This is the contents of my .git-submodule-status file: >> #!/bin/sh > [...] > > That were the contents of scripts/git-submodule.sh. I meant the hidden > file .git-submodule-status in the main directory.
This is it: 88f18909db731a627456f26d779445f84e449536 dtc (v1.4.7) f0da6726207b740f6101028b2992f918477a4b08 slirp (v4.0.0-rc0-25-gf0da672) b64af41c3276f97f0e181920400ee056b9c88037 tests/fp/berkeley-softfloat-3 (heads/master) 5a59dcec19327396a011a17fd924aed4fec416b3 tests/fp/berkeley-testfloat-3 (remotes/origin/HEAD) 6b3d716e2b6472eb7189d3220552280ef3d832ce ui/keycodemapdb (heads/master-4-g6b3d716) > >> I did a 'make clean' followed by a 'make distclean'. Then tried building >> again using this command line: >> >> ./configure --target-list=ppc-softmmu,i386-softmmu,x86_64-softmmu >> make -j 4 > > That should normally populate the capstone directory. What happens if > you run "make git-submodule-update" directly? Here is the result: $ make git-submodule-update make[1]: Nothing to be done for `all'. make[1]: *** No rule to make target `/Users/John/Documents/Development/Projects/Qemu/qemu-git/capstone/libcapstone.a'. Stop. make: *** [subdir-capstone] Error 2 >> Here is the error message I see: >> >> make[1]: *** No rule to make target >> `/Users/John/Documents/Development/Projects/Qemu/qemu-git/capstone/libcapstone.a'. >> Stop. >> make: *** [subdir-capstone] Error 2 >> >> I took a look at the capstone folder. There is no 'make' file in this >> folder. Should there be one? > > Yes, the capstone folder should be populated automatically. Is it > completely empty for you? It isn't empty. All I see are two folders: obj and docs. Thank you.