On Mon 13 May 2019 04:31:16 PM CEST, Max Reitz wrote: >> @@ -2569,10 +2582,6 @@ BdrvChild *bdrv_open_child(const char *filename, >> } >> >> c = bdrv_attach_child(parent, bs, bdref_key, child_role, errp); >> - if (!c) { >> - bdrv_unref(bs); >> - return NULL; >> - } >> >> return c; >> } > > (That could have been simplified even further. *shrug*)
Right, we can remove the 'c' variable altogether. Feel free to edit the commit if you want. Berto