On Mon, 13 May 2019 at 17:56, Palmer Dabbelt <pal...@sifive.com> wrote: > > On Mon, 13 May 2019 01:18:39 PDT (-0700), arm...@redhat.com wrote: > > Reuse of the same guard symbol in multiple headers is okay as long as > > they cannot be included together. scripts/clean-header-guards.pl > > can't tell, so it warns. > > > > Since we can avoid guard symbol reuse easily, do so: use guard symbol > > ${target^^}_${fname^^} for linux-user/$target/$fname, just like we did > > in commit a9c94277f0..3500385697. > > > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > > Message-Id: <20190315145123.28030-4-arm...@redhat.com> > > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> Reviewed-by: Palmer Dabbelt <pal...@sifive.com> > > I'm assuming this is going in through someone else's tree, so I'm not going to > pick it up into mine. The subject line says "PULL" rather than "PATCH", so it is already going into master (indeed I just applied it). In general there's not much point in commenting on patches in pull requests on the lists except for "this has a problem, please don't apply it" feedback. (In that case you should reply to the cover letter, because I won't necessarily see replies to individual patches in the pull before I apply the pull.) thanks -- PMM