On Mon, May 13, 2019 at 05:37:09PM +0200, Markus Armbruster wrote: > Andrew Jones <drjo...@redhat.com> writes: > > > Allow the host cpu type to enable SVE in guests with the sve-vls-map > > cpu property. > > > > Signed-off-by: Andrew Jones <drjo...@redhat.com> > > --- > > target/arm/cpu.c | 1 + > > target/arm/cpu.h | 2 ++ > > target/arm/cpu64.c | 12 +++++++++--- > > 3 files changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > > index ea0e24bba8b6..a5c01ff42c78 100644 > > --- a/target/arm/cpu.c > > +++ b/target/arm/cpu.c > > @@ -2222,6 +2222,7 @@ static void arm_host_initfn(Object *obj) > > ARMCPU *cpu = ARM_CPU(obj); > > > > kvm_arm_set_cpu_features_from_host(cpu); > > + aarch64_add_sve_vls_map_property(obj); > > arm_cpu_post_init(obj); > > } > > > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > > index f0d0ce759ba8..13731ccb39f3 100644 > > --- a/target/arm/cpu.h > > +++ b/target/arm/cpu.h > > @@ -976,11 +976,13 @@ int aarch64_cpu_gdb_write_register(CPUState *cpu, > > uint8_t *buf, int reg); > > void aarch64_sve_narrow_vq(CPUARMState *env, unsigned vq); > > void aarch64_sve_change_el(CPUARMState *env, int old_el, > > int new_el, bool el0_a64); > > +void aarch64_add_sve_vls_map_property(Object *obj); > > #else > > static inline void aarch64_sve_narrow_vq(CPUARMState *env, unsigned vq) { } > > static inline void aarch64_sve_change_el(CPUARMState *env, int o, > > int n, bool a) > > { } > > +void aarch64_add_sve_vls_map_property(Object *obj) { } > > qemu/target/arm/cpu.h:985:6: error: no previous prototype for > ‘aarch64_add_sve_vls_map_property’ [-Werror=missing-prototypes] > void aarch64_add_sve_vls_map_property(Object *obj) { } > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Did you forget static inline?
I sure did. Thanks for finding this! drew > > > #endif > > > > target_ulong do_arm_semihosting(CPUARMState *env); > [...]