On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > On May 10, 2019 10:36 PM, "Richard Henderson" <richard.hender...@linaro.org > <mailto:richard.hender...@linaro.org>> wrote: >> >> For linux-user, there is no need to add slirp to the set of >> git modules checked out, nor build it. >> >> This also avoids a makefile bug wrt insufficient dependencies >> on subdir-slirp. If slirp/ is not initially present, the >> dependencies that check it out are associated with softmmu, >> which then generates a build error on slirp/ not present. >> > > Hi, > > Does this work if only user mode targets are specified via ˊ--target-listˊ > switch?
Yes. There is a bit of code that converts such a target list to the same result as --disable-system, which is $softmmu = no. > If no, the patch shoud be amended. If yes, the commit message should be > extended. Like what? I think it's pretty clear as is. r~
