Re: [Qemu-devel] [PATCH v4 3/3] virtio-rng: change default backend to rng-builtin

[Laurent Vivier]

On 14/05/2019 17:24, Markus Armbruster wrote:

Laurent Vivier <lviv...@redhat.com> writes:

Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
  backends/rng-builtin.c         |  8 +++-----
  hw/virtio/virtio-rng.c         |  2 +-
  include/hw/virtio/virtio-rng.h |  4 ++--
  include/sysemu/rng-builtin.h   | 17 +++++++++++++++++
  qemu-options.hx                |  5 ++---
  5 files changed, 25 insertions(+), 11 deletions(-)
  create mode 100644 include/sysemu/rng-builtin.h

diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c
index b1264b745407..27675301933b 100644
--- a/backends/rng-builtin.c
+++ b/backends/rng-builtin.c
@@ -7,17 +7,15 @@

#include "qemu/osdep.h"

  #include "sysemu/rng.h"
+#include "sysemu/rng-builtin.h"
  #include "qapi/error.h"
  #include "qapi/qmp/qerror.h"
  #include "qemu/main-loop.h"
  #include "qemu/guest-random.h"

-#define TYPE_RNG_BUILTIN "rng-builtin"

-#define RNG_BUILTIN(obj) OBJECT_CHECK(RngBuiltin, (obj), TYPE_RNG_BUILTIN)
-
-typedef struct RngBuiltin {
+struct RngBuiltin {
      RngBackend parent;
-} RngBuiltin;
+};

static void rng_builtin_request_entropy(RngBackend *b, RngRequest *req)

  {

Rebase on top of the PATCH 3.5 I just posted gets rid of patch hunks
from here...

I will resend the series including your patch.

Thanks,
Laurent