On 5/14/19 5:52 PM, Alex Bennée wrote: > Clean-up our unimplemented bits with a proper message. > > Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > target/arm/arm-semi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c > index 253c66b172a..a3bbef18ef7 100644 > --- a/target/arm/arm-semi.c > +++ b/target/arm/arm-semi.c > @@ -28,6 +28,7 @@ > #include "cpu.h" > #include "hw/semihosting/semihost.h" > #include "hw/semihosting/console.h" > +#include "qemu/log.h" > #ifdef CONFIG_USER_ONLY > #include "qemu.h" > > @@ -366,7 +367,7 @@ target_ulong do_arm_semihosting(CPUARMState *env) > return len - ret; > } > case TARGET_SYS_READC: > - /* XXX: Read from debug console. Not implemented. */ > + qemu_log_mask(LOG_UNIMP, "%s: SYS_READC not implemented", __func__); > return 0; > case TARGET_SYS_ISTTY: > GET_ARG(0); > @@ -400,7 +401,7 @@ target_ulong do_arm_semihosting(CPUARMState *env) > return buf.st_size; > } > case TARGET_SYS_TMPNAM: > - /* XXX: Not implemented. */ > + qemu_log_mask(LOG_UNIMP, "%s: SYS_TMPNAM not implemented", __func__); > return -1; > case TARGET_SYS_REMOVE: > GET_ARG(0); >
