Jon Doron <ari...@gmail.com> writes:
> Follow GDB general query/set packet conventions, qemu.sstep can now
> be set with the following command as well:
> gdb> maint packet Qqemu.sstep:Value
I;m not sure about exposing internal values to a protocol like this.
Maybe text based flags would be better?
>
> Signed-off-by: Jon Doron <ari...@gmail.com>
> ---
> gdbstub.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 88ff6224e6..34da10260d 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2260,6 +2260,12 @@ static GdbCmdParseEntry gdb_gen_set_table[] = {
> .cmd_startswith = 1,
> .schema = "l0"
> },
> + {
> + .handler = handle_set_qemu_sstep,
> + .cmd = "qemu.sstep:",
> + .cmd_startswith = 1,
> + .schema = "l0"
> + },
Hmm the implementation seems to have gone in earlier. These should be
together as a feature patch (along with changing the query/probe
responses).
> };
>
> static void handle_gen_query(GdbCmdContext *gdb_ctx, void *user_ctx)
--
Alex Bennée
