On 18 April 2011 17:39, Stefan Weil <w...@mail.berlios.de> wrote: > Function gen_pc_load was introduced in commit > d2856f1ad4c259e5766847c49acbb4e390731bd4. > The only reason for parameter searched_pc was > a debug statement in target-i386/translate.c. > > Parameter puc was needed by target-sparc until > commit d2856f1ad4c259e5766847c49acbb4e390731bd4.
Don't you mean d7da2a10402f1644128b66414ca8f86bdea9ae7c ? > diff --git a/target-arm/translate.c b/target-arm/translate.c > index 6190028..7e7652e 100644 > --- a/target-arm/translate.c > +++ b/target-arm/translate.c > @@ -9551,8 +9551,8 @@ static inline void > gen_intermediate_code_internal(CPUState *env, > * This is handled in the same way as restoration of the > * PC in these situations: we will be called again with search_pc=1 > * and generate a mapping of the condexec bits for each PC in > - * gen_opc_condexec_bits[]. gen_pc_load[] then uses this to restore > - * the condexec bits. > + * gen_opc_condexec_bits[]. restore_state_to_opc[] then uses > + * this to restore the condexec bits. If you have to do another round of this patch then you could make that say "restore_state_to_opc()" (round brackets rather than square), but it's not worth doing a fresh round just to fix an existing typo. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> -- PMM