On Thu, 16 May 2019 13:01:31 +0200 Philippe Mathieu-Daudé <phi...@redhat.com> wrote:
> On Thu, May 16, 2019 at 9:41 AM Wei Yang <richardw.y...@linux.intel.com> > wrote: > > > > On Wed, May 15, 2019 at 07:29:17AM +0200, Philippe Mathieu-Daudé wrote: > > > > > >Thanks Michael for testing... > > > > > >Wei, can you add a MCFG test in tests/bios-tables-test.c? > > > > > > > I took a look into the test, current q35 has already has a reference MCFG in > > tests/data/acpi/q35/MCFG. > > > > And there would be a warning message when reserved[8] is missed. > > > > /x86_64/acpi/q35/bridge: acpi-test: Warning! MCFG mismatch. > > > > Is this enough? Or what more information prefer to add? > > Well, the test has to fail for any mismatch (not a simple warning). > > A mismatch failure seems to be enough IMHO. Warning is sufficient, we do not fail ACPI tests on mismatch. It was a policy decision for APCI tests as far as I remember. We might reconsider it in the future but it shouldn't affect this patch. > > > >>> - AcpiMcfgAllocation allocation[0]; > > >>> -} QEMU_PACKED; > > >>> -typedef struct AcpiTableMcfg AcpiTableMcfg; > > >>> - > > >>> /* > > >>> * TCPA Description Table > > >>> * > > >>> -- > > >>> 2.19.1 > > > > -- > > Wei Yang > > Help you, Help me >