On 5/20/19 9:47 AM, Cédric Le Goater wrote: > Hello, > > On 5/6/19 4:20 PM, Cédric Le Goater wrote: >> Hello, >> >> Here is a series adding a couple of cleanups to the Aspeed SoCs to >> prepare ground for extensions and new SoCs. >> >> Thanks, >> >> C. >> >> Changes since v1: >> >> - moved enum defining the Aspeed controller names under aspeed_soc.h >> - removed AspeedSoCInfo 'sdram_base' field >> - fixed clang compilation >> >> Cédric Le Goater (3): >> aspeed: add a per SoC mapping for the interrupt space >> aspeed: add a per SoC mapping for the memory space > > I think these two patches are fine to go even if Philippe's comments > are not addressed. There are valid but not a blocker to me.
OK, so: patches 1 & 2: Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Peter, can you apply them? > >> aspeed: use sysbus_init_child_obj() to initialize children > > Philippe has taken over this patch in a larger series which will go > through Eduardo's tree, if I understood well the emails. When merged, > we can try to re-merge the RTC patchset from Joel. I think we made > things a little more complex than they should have been. Sorry if I made things more complex. I went on PTO after sending "hw/arm: Use object_initialize_child for correct reference counting" [*] then was slow to address Thomas/Markus comments. Then maybe I should start pinging maintainer more aggressively when my series are reviewed but not merged, to not delay further developments. I took note of your comment and will try to keep things simple the next time. Regards, Phil. > > Thanks, > > C.
