On Fri, 10 May 2019 at 17:37, Kevin Wolf <kw...@redhat.com> wrote: > > From: Max Reitz <mre...@redhat.com> > > Currently, without -u, you cannot add a backing file to an image when it > currently has none: > > $ qemu-img rebase -b base.qcow2 foo.qcow2 > qemu-img: Could not open old backing file '': The 'file' block driver > requires a file name > > It is really simple to allow this, though (effectively by setting > old_backing_size to 0), so this patch does just that. > > Signed-off-by: Max Reitz <mre...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Kevin Wolf <kw...@redhat.com>
Hi -- Coverity reports some new "resource leak" errors in the qemu-img.c img_rebase() function: * CID 1401415 : Coverity complains that the memory assigned to out_real_path gets leaked if we take the immediately following "if (local_err) ... goto out" error-exit path. This may be another instance of Coverity not understanding that the function won't return non-NULL if errp is set. * CID 1401416 : leak of the 'options' qdict in this error-exit code path. This looks like a real issue (and there seem to be other error-exit codepaths earlier in the function which leak this too.) Would somebody like to have a look at these? thanks -- PMM
