On (Tue) 19 Apr 2011 [14:36:43], Kevin Wolf wrote: > diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c > index 032d1b0..88e7791 100644 > --- a/hw/ide/atapi.c > +++ b/hw/ide/atapi.c > @@ -813,11 +813,7 @@ error_cmd: > > static void cmd_test_unit_ready(IDEState *s, uint8_t *buf) > { > - if (bdrv_is_inserted(s->bs)) { > - ide_atapi_cmd_ok(s); > - } else { > - ide_atapi_cmd_error(s, SENSE_NOT_READY, ASC_MEDIUM_NOT_PRESENT); > - } > + ide_atapi_cmd_ok(s); > }
It'll look really weird to have test_unit_ready() to always return GOOD status (outside the context of this patch). A comment will help. Amit