On 10.05.19 21:03, John Snow wrote: > Don't pull events out of the queue that don't belong to us; > be choosier so that we can use this method to drive jobs that > were launched by transactions that may have more jobs. > > Signed-off-by: John Snow <js...@redhat.com> > --- > tests/qemu-iotests/iotests.py | 32 +++++++++++++++----------------- > 1 file changed, 15 insertions(+), 17 deletions(-)
There are a couple of conflicts because of concurrent patches to run_job now. I resolved those, but then noticed that the tests 245 and 255 no longer pass; their reference output contains events like BLOCK_JOB_PENDING and BLOCK_JOB_COMPLETED. I’m not sure whether we should remove those event from the output. It feels weird to me to keep them somewhere in the back log and not show them in tests that by design have kind of a full QMP log. On the other hand, I see that this patch is necessary. Ideally, I think run_job should log all events that relate to the job at hand -- but our current event_wait() matching system doesn’t allow that. Ideas? :-/ Max
signature.asc
Description: OpenPGP digital signature
