Hi all! Bitmaps reopening is buggy, we may easily produce broken incremental backup if we do temporary snaphost. Let's fix it! The main patch is 03 and it has full description of the problem and solution.
Vladimir Sementsov-Ogievskiy (3): iotests: add test 255 to check bitmap life after snapshot + commit block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps block/qcow2-bitmap: rewrite bitmap reopening logic block/qcow2.h | 5 +- include/block/block_int.h | 2 +- include/block/dirty-bitmap.h | 1 - block.c | 29 ++--- block/dirty-bitmap.c | 12 -- block/qcow2-bitmap.c | 220 ++++++++++++++++++++++++----------- block/qcow2.c | 2 +- python/qemu/__init__.py | 4 +- tests/qemu-iotests/255 | 83 +++++++++++++ tests/qemu-iotests/255.out | 52 +++++++++ tests/qemu-iotests/group | 1 + 11 files changed, 308 insertions(+), 103 deletions(-) create mode 100755 tests/qemu-iotests/255 create mode 100644 tests/qemu-iotests/255.out -- 2.18.0
