On Mon, May 27, 2019 at 01:33:27PM +0530, Aarushi Mehta wrote: > @@ -1920,24 +1947,40 @@ static int coroutine_fn > raw_co_pwritev(BlockDriverState *bs, uint64_t offset, > > static void raw_aio_plug(BlockDriverState *bs) > { > -#ifdef CONFIG_LINUX_AIO > +#if defined CONFIG_LINUX_AIO || defined CONFIG_LINUX_IO_URING > BDRVRawState *s = bs->opaque; > +#endif
It would be nice to avoid the extra ifdefs. Here is an alternative without #ifdef: BDRVRawState __attribute__((unused)) *s = bs->opaque; > @@ -1963,8 +2006,10 @@ static int raw_co_flush_to_disk(BlockDriverState *bs) > static void raw_aio_attach_aio_context(BlockDriverState *bs, > AioContext *new_context) > { > +#if defined CONFIG_LINUX_AIO || defined CONFIG_LINUX_IO_URING > + BDRVRawState *s = bs->opaque; Indentation?
signature.asc
Description: PGP signature