On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote: > We have a bunch of headers without multiple inclusion guards. Some are > clearly intentional, some look accidental. Too many for me to find out > by examining each of them, so I'm asking their maintainers. > > Why do I ask? I'd like to mark the intentional ones and fix the > accidental ones, so they don't flunk "make check-headers" from "[RFC v4 > 0/7] Baby steps towards saner headers" just because they lack multiple > inclusion guards. > > Just in case: what's a multiple inclusion guard? It's > > #ifndef UNIQUE_GUARD_SYMBOL_H > #define UNIQUE_GUARD_SYMBOL_H > ... > #endif > > with nothing but comments outside the conditional, so that the header > can safely be included more than once. > > I append the alphabetical list of headers without multiple inclusion > guards (as reported by scripts/clean-header-guards -nv), followed by the > same list sorted into maintainer buckets. If you're cc'ed, please find > your bucket(s), and tell me which headers intentionally lack guards.
[snip]
> PowerPC
> M: David Gibson <da...@gibson.dropbear.id.au>
> target/ppc/helper.h
Like the equivalent ARM variants, intentional.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
