On 30/05/19 10:42, Kevin Wolf wrote: > Am 27.05.2019 um 11:23 hat Stefan Hajnoczi geschrieben: >> qemu_aio_get() does not zero allocated memory. Explicitly initialize >> laiocb->co to prevent an uninitialized memory access in >> qemu_laio_process_completion(). >> >> Note that this bug has never manifested itself. I guess we're lucky! >> >> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > That the bug never manifested itself might be because it's in an unused > function. How about we finally just remove the unused callback-based > laio_submit() from the code? > > At the time when I converted linux-aio to coroutines, someone (maybe > Paolo?) insisted that we keep the old interface because we might add a > new user sometime with possible shortcuts that bypass the whole coroutine > path, but it hasn't happened and I think we've moved even further in the > opposite direction since then.
Yes, I suppose it's time. Spending time fixing bugs in dead code is always a sign that it's time. :) Paolo
