On Sun, Jun 02, 2019 at 01:42:13PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kis...@siemens.com>
>
> Masked entries will not generate interrupt messages, thus do no need to
> be routed by KVM. This is a cosmetic cleanup, just avoiding warnings of
> the kind
>
> qemu-system-x86_64: vtd_irte_get: detected non-present IRTE (index=0,
> high=0xff00, low=0x100)
>
> if the masked entry happens to reference a non-present IRTE.
>
> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> hw/intc/ioapic.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
> index 7074489fdf..2fb288a22d 100644
> --- a/hw/intc/ioapic.c
> +++ b/hw/intc/ioapic.c
> @@ -197,9 +197,11 @@ static void ioapic_update_kvm_routes(IOAPICCommonState
> *s)
> MSIMessage msg;
> struct ioapic_entry_info info;
> ioapic_entry_parse(s->ioredtbl[i], &info);
> - msg.address = info.addr;
> - msg.data = info.data;
> - kvm_irqchip_update_msi_route(kvm_state, i, msg, NULL);
> + if (!info.masked) {
> + msg.address = info.addr;
> + msg.data = info.data;
> + kvm_irqchip_update_msi_route(kvm_state, i, msg, NULL);
> + }
> }
> kvm_irqchip_commit_routes(kvm_state);
> }
> --
> 2.16.4
