On 08/01/2019 23:45, David Gibson wrote: > From: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > > These helpers allow us to move VSR register values to/from the specified > TCGv_i64 > argument. > > To prevent VSX helpers accessing the cpu_vsr array directly, add extra TCG > temporaries as required. > > Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > Acked-by: David Gibson <da...@gibson.dropbear.id.au> > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au> > --- > target/ppc/translate/vsx-impl.inc.c | 862 ++++++++++++++++++++-------- > 1 file changed, 638 insertions(+), 224 deletions(-) >
This patch breaks something in the libcrypto. I've been able to reproduce the problem with Fedora 29: dnf install 'dnf-command(download)' dnf download --source coreutils-single rpm --verify coreutils-8.30-7.fc29.src.rpm error: coreutils-8.30-7.fc29.src.rpm: Header V3 RSA/SHA256 Signature, key ID 429476b4: BAD error: coreutils-8.30-7.fc29.src.rpm: Header SHA256 digest: BAD (Expected fa042669e74ac435bd5defaa8c2e4efe779a0329c24f2b6377591c53b38aa280 != d6e22527412fafc4aa12882432d0d157e5427097710eeb2d5fce8fbc52a47be6) error: coreutils-8.30-7.fc29.src.rpm: not an rpm package (or package manifest) See https://bugzilla.redhat.com/show_bug.cgi?id=1715017 I've tested with origin/master (47fbad45d47af8af784bb12a5719489edcd89b4c) and all the merged fixes for this patch don't fix this problem. We should be able to reproduce it on Debian Sid too: it breaks ssh (this is one of the rare binaries using libcrypto on debian). I've been able to reproduce it with qemu linux-user if I enable PPC_FEATURE2_VEC_CRYPTO in linux-user/elfload.c (git clone -b linux-user-ppc64-hwcap g...@github.com:vivier/qemu.git). To ease debugging, you can install a Fedora 29 chroot with something like: curl -o container.tar.xz http://download-ib01.fedoraproject.org/pub/fedora-secondary/releases/29/Container/ppc64le/images/Fedora-Container-Base-29-1.2.ppc64le.tar.xz tar Jxvf container.tar.xz '*/layer.tar' mkdir -p chroot/ppc64le/29 cd chroot/ppc64le/29 tar xf $OLDPWD/*/layer.tar cd - cp ~/qemu/ppc64le-linux-user/qemu-ppc64le chroot/ppc64le/29/ [use "configure --target-list=ppc64le-linux-user --static --disable-tools" and don't forget to run scripts/qemu-binfmt-conf.sh] Thanks, Laurent
