Laurent Vivier <lviv...@redhat.com> writes: > Add a new RNG backend using QEMU builtin getrandom function. > > It can be created and used with something like: > > ... -object rng-builtin,id=rng0 -device virtio-rng,rng=rng0 ... > > Signed-off-by: Laurent Vivier <lviv...@redhat.com> > --- > backends/Makefile.objs | 2 +- > backends/rng-builtin.c | 78 ++++++++++++++++++++++++++++++++++++++++++ > qemu-options.hx | 7 ++++ > 3 files changed, 86 insertions(+), 1 deletion(-) > create mode 100644 backends/rng-builtin.c > > diff --git a/backends/Makefile.objs b/backends/Makefile.objs > index 981e8e122f2c..f0691116e86e 100644 > --- a/backends/Makefile.objs > +++ b/backends/Makefile.objs > @@ -1,4 +1,4 @@ > -common-obj-y += rng.o rng-egd.o > +common-obj-y += rng.o rng-egd.o rng-builtin.o > common-obj-$(CONFIG_POSIX) += rng-random.o > > common-obj-$(CONFIG_TPM) += tpm.o > diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c > new file mode 100644 > index 000000000000..3381d47174df > --- /dev/null > +++ b/backends/rng-builtin.c > @@ -0,0 +1,78 @@ > +/* > + * QEMU Builtin Random Number Generator Backend > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > + > +#include "qemu/osdep.h" > +#include "sysemu/rng.h" > +#include "qemu/main-loop.h" > +#include "qemu/guest-random.h" > + > +#define TYPE_RNG_BUILTIN "rng-builtin" > +#define RNG_BUILTIN(obj) OBJECT_CHECK(RngBuiltin, (obj), TYPE_RNG_BUILTIN) > + > +typedef struct RngBuiltin { > + RngBackend parent; > + QEMUBH *bh; > +} RngBuiltin; > + > +static void rng_builtin_receive_entropy_bh(void *opaque) > +{ > + RngBuiltin *s = opaque; > + > + while (!QSIMPLEQ_EMPTY(&s->parent.requests)) { > + RngRequest *req = QSIMPLEQ_FIRST(&s->parent.requests); > + > + qemu_guest_getrandom_nofail(req->data, req->size); > + > + req->receive_entropy(req->opaque, req->data, req->size); > + > + rng_backend_finalize_request(&s->parent, req); > + } > +} > + > +static void rng_builtin_request_entropy(RngBackend *b, RngRequest *req) > +{ > + RngBuiltin *s = RNG_BUILTIN(b); > + > + qemu_bh_schedule(s->bh); > +}
A comment explaining the need for a BH would be nice. Regardless: Reviewed-by: Markus Armbruster <arm...@redhat.com> [...]