On 6/6/19 1:41 PM, John Snow wrote: > Similarly to the previous commit, we need to also keep a ledger of the > additional directory size burden that we've not yet committed so we can > reject new additions sooner instead of later. > > Signed-off-by: John Snow <js...@redhat.com> > --- > block/qcow2.h | 1 + > block/qcow2-bitmap.c | 13 ++++++++++++- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/block/qcow2.h b/block/qcow2.h > index ebf60ac236..5aff97eb9c 100644 > --- a/block/qcow2.h > +++ b/block/qcow2.h > @@ -318,6 +318,7 @@ typedef struct BDRVQcow2State { > > uint32_t nb_bitmaps; > uint32_t nb_queued_bitmaps; > + uint32_t queued_directory_size; > uint64_t bitmap_directory_size;
Why can we get away with uint32_t for the queue size, but uint64_t for the stored size? Something feels fishy. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature