> > > -------- Original Message -------- > Subject: Re: [Qemu-devel] [PATCH 0/8] Optimize emulation of ten Altivec > instructions: lvsl, > Date: Thursday, June 6, 2019 19:13 CEST > From: Richard Henderson <richard.hender...@linaro.org> > To: Stefan Brankovic <stefan.branko...@rt-rk.com>, qemu-devel@nongnu.org > CC: da...@gibson.dropbear.id.au > References: <1559816130-17113-1-git-send-email-stefan.branko...@rt-rk.com> > > > > > On 6/6/19 5:15 AM, Stefan Brankovic wrote: > > > Stefan Brankovic (8): > > > target/ppc: Optimize emulation of lvsl and lvsr instructions > > > target/ppc: Optimize emulation of vsl and vsr instructions > > > target/ppc: Optimize emulation of vpkpx instruction > > > target/ppc: Optimize emulation of vgbbd instruction > > > target/ppc: Optimize emulation of vclzd instruction > > > target/ppc: Optimize emulation of vclzw instruction > > > target/ppc: Optimize emulation of vclzh and vclzb instructions > > > target/ppc: Refactor emulation of vmrgew and vmrgow instructions > > > > > > target/ppc/translate/vmx-impl.inc.c | 705 > > > ++++++++++++++++++++++++++++++++---- > > > 1 file changed, 636 insertions(+), 69 deletions(-) > > > > You should be removing the out-of-line helpers that are no longer used. > >
Thank you for taking your time to review my code. I think that your suggestions are all constructive and very useful. However, I was on a short leave this week and I couldn't respond promptly. I will respond with more details in next few days. Kind Regards, Stefan > > > > r~ > > >
