Patchew URL: https://patchew.org/QEMU/20190614171200.21078-1-alex.ben...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190614171200.21078-1-alex.ben...@linaro.org Type: series Subject: [Qemu-devel] [PATCH v3 00/50] tcg plugin support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 049048f TODO: API changes to make? ed124e9 include/exec/cpu-defs.h: fix typo f5a1e5b include/exec: wrap cpu_ldst.h in CONFIG_TCG 9ba123b accel/stubs: reduce headers from tcg-stub df9793f tests/plugin: add hotpages plugin to breakdown memory access patterns d1f355e tests/plugin: add instruction execution breakdown 6d4683c plugin: add qemu_plugin_insn_disas helper e3145c6 tests/plugin: add a hotblocks plugin 473cace tests/tcg: enable plugin testing c99d2ca tests/plugin: add sample plugins f92b641 linux-user: support -plugin option f81dc94 vl: support -plugin option 11d158f plugin: add API symbols to qemu-plugins.symbols d0af116 translator: inject instrumentation from plugins 075f779 target/openrisc: fetch code with translator_ld 6426594 target/xtensa: fetch code with translator_ld 38fa0bd target/sparc: fetch code with translator_ld 96a7c87 target/riscv: fetch code with translator_ld 2bbeaea target/alpha: fetch code with translator_ld 2a3f91f target/m68k: fetch code with translator_ld 86b0923 target/hppa: fetch code with translator_ld 206cd1e target/i386: fetch code with translator_ld c7ffbb8 target/sh4: fetch code with translator_ld 23bae27 target/ppc: fetch code with translator_ld 04e9634 target/arm: call qemu_plugin_insn_append 90c2eaa translator: add translator_ld{ub, sw, uw, l, q} 9681e1f plugin-gen: add plugin_insn_append 6c03f40 cpu: hook plugin vcpu events aa70581 *-user: plugin syscalls d9de19e *-user: notify plugin of exit 2a222c5 translate-all: notify plugin code of tb_flush fa91333 tcg: let plugins instrument memory accesses 3644ead cpu_ldst_useronly_template: remove redundant #ifndef CODE_ACCESS ab9dbec atomic_template: add inline trace/plugin helpers e4aef56 atomic_template: fix indentation in GEN_ATOMIC_HELPER ee3eba8 tcg: add MO_HADDR to TCGMemOp 3760a15 tcg: add tcg_gen_st_ptr a4af748 plugin-gen: add module for TCG-related code 7f9020a cputlb: introduce get_page_addr_code_hostp 9a46037 cputlb: document get_page_addr_code 6d8e505 queue: add QTAILQ_REMOVE_SEVERAL a3f7fb1 plugin: add implementation of the api 1bd3802 plugin: add core code eb7a5d5 plugin: add user-facing API 33d885f configure: add --enable-plugins (MOVE TO END) 3fd3aeb docs/devel: add plugins.rst design document dd4b2c0 translate-all: use cpu_in_exclusive_work_context() in tb_flush 6ef20c7 cpu: introduce cpu_in_exclusive_work_context() 8995c5a tcg/README: fix typo s/afterwise/afterwards/ b13029e trace: expand mem_info:size_shift to 3 bits === OUTPUT BEGIN === 1/50 Checking commit b13029ec3c61 (trace: expand mem_info:size_shift to 3 bits) 2/50 Checking commit 8995c5a5814a (tcg/README: fix typo s/afterwise/afterwards/) 3/50 Checking commit 6ef20c7ac84b (cpu: introduce cpu_in_exclusive_work_context()) 4/50 Checking commit dd4b2c0b5d58 (translate-all: use cpu_in_exclusive_work_context() in tb_flush) 5/50 Checking commit 3fd3aeb92699 (docs/devel: add plugins.rst design document) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 total: 0 errors, 1 warnings, 103 lines checked Patch 5/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/50 Checking commit 33d885f24794 (configure: add --enable-plugins (MOVE TO END)) 7/50 Checking commit eb7a5d579131 (plugin: add user-facing API) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 WARNING: architecture specific defines should be avoided #41: FILE: include/qemu/qemu-plugin.h:22: +#if defined _WIN32 || defined __CYGWIN__ WARNING: architecture specific defines should be avoided #49: FILE: include/qemu/qemu-plugin.h:30: + #if __GNUC__ >= 4 total: 0 errors, 3 warnings, 339 lines checked Patch 7/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/50 Checking commit 1bd3802f7e55 (plugin: add core code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #56: new file mode 100644 ERROR: "foo * bar" should be "foo *bar" #197: FILE: include/qemu/plugin.h:137: +static inline struct qemu_plugin_insn * qemu_plugin_insn_alloc(void) WARNING: Block comments use a leading /* on a separate line #371: FILE: plugins/core.c:1: +/* plugin.c - QEMU Plugin interface ERROR: named QLIST_HEAD should be typedefed separately #407: FILE: plugins/core.c:37: +QLIST_HEAD(qemu_plugin_cb_head, qemu_plugin_cb); WARNING: line over 80 characters #626: FILE: plugins/core.c:256: + cbs = g_array_sized_new(false, false, sizeof(struct qemu_plugin_dyn_cb), 1); WARNING: Block comments use a leading /* on a separate line #942: FILE: plugins/loader.c:42: + { /* end of list */ } ERROR: externs should be avoided in .c files #948: FILE: plugins/loader.c:48: +extern struct qemu_plugin_state plugin; total: 3 errors, 4 warnings, 1294 lines checked Patch 8/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/50 Checking commit a3f7fb1c3afd (plugin: add implementation of the api) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 271 lines checked Patch 9/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/50 Checking commit 6d8e50569c13 (queue: add QTAILQ_REMOVE_SEVERAL) WARNING: Block comments use a leading /* on a separate line #30: FILE: include/qemu/queue.h:433: + } while (/*CONSTCOND*/0) total: 0 errors, 1 warnings, 16 lines checked Patch 10/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/50 Checking commit 9a46037bfb3b (cputlb: document get_page_addr_code) 12/50 Checking commit 7f9020af50d0 (cputlb: introduce get_page_addr_code_hostp) 13/50 Checking commit a4af74838a09 (plugin-gen: add module for TCG-related code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 1273 lines checked Patch 13/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/50 Checking commit 3760a1583150 (tcg: add tcg_gen_st_ptr) 15/50 Checking commit ee3eba82d0e6 (tcg: add MO_HADDR to TCGMemOp) 16/50 Checking commit e4aef56e6d7b (atomic_template: fix indentation in GEN_ATOMIC_HELPER) 17/50 Checking commit ab9dbecd0947 (atomic_template: add inline trace/plugin helpers) 18/50 Checking commit 3644ead62d44 (cpu_ldst_useronly_template: remove redundant #ifndef CODE_ACCESS) 19/50 Checking commit fa91333b879c (tcg: let plugins instrument memory accesses) ERROR: line over 90 characters #224: FILE: accel/tcg/plugin-gen.c:98: + tcg_gen_ld_i32(cpu_index, cpu_env, -offsetof(ArchCPU, env) + offsetof(CPUState, cpu_index)); total: 1 errors, 0 warnings, 542 lines checked Patch 19/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/50 Checking commit 2a222c5a56d6 (translate-all: notify plugin code of tb_flush) 21/50 Checking commit d9de19e4841b (*-user: notify plugin of exit) 22/50 Checking commit aa7058138134 (*-user: plugin syscalls) 23/50 Checking commit 6c03f4039c79 (cpu: hook plugin vcpu events) 24/50 Checking commit 9681e1f77508 (plugin-gen: add plugin_insn_append) 25/50 Checking commit 90c2eaa2247d (translator: add translator_ld{ub, sw, uw, l, q}) WARNING: Block comments use a leading /* on a separate line #49: FILE: include/exec/translator.h:166: +GEN_TRANSLATOR_LD(translator_ldub, ldub, uint8_t, /* no swap needed */) total: 0 errors, 1 warnings, 40 lines checked Patch 25/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/50 Checking commit 04e963494144 (target/arm: call qemu_plugin_insn_append) 27/50 Checking commit 23bae27d37b4 (target/ppc: fetch code with translator_ld) 28/50 Checking commit c7ffbb8780fb (target/sh4: fetch code with translator_ld) 29/50 Checking commit 206cd1e53cc9 (target/i386: fetch code with translator_ld) 30/50 Checking commit 86b0923359a8 (target/hppa: fetch code with translator_ld) 31/50 Checking commit 2a3f91fd39e9 (target/m68k: fetch code with translator_ld) 32/50 Checking commit 2bbeaea354dc (target/alpha: fetch code with translator_ld) 33/50 Checking commit 96a7c87ae19f (target/riscv: fetch code with translator_ld) 34/50 Checking commit 38fa0bd596fd (target/sparc: fetch code with translator_ld) 35/50 Checking commit 642659499636 (target/xtensa: fetch code with translator_ld) 36/50 Checking commit 075f7795fe2c (target/openrisc: fetch code with translator_ld) 37/50 Checking commit d0af1163d422 (translator: inject instrumentation from plugins) 38/50 Checking commit 11d158f19449 (plugin: add API symbols to qemu-plugins.symbols) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #120: new file mode 100644 total: 0 errors, 1 warnings, 148 lines checked Patch 38/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 39/50 Checking commit f81dc947d361 (vl: support -plugin option) 40/50 Checking commit f92b641790b2 (linux-user: support -plugin option) 41/50 Checking commit c99d2cab03ae (tests/plugin: add sample plugins) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 total: 0 errors, 1 warnings, 296 lines checked Patch 41/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 42/50 Checking commit 473cace55471 (tests/tcg: enable plugin testing) 43/50 Checking commit e3145c6f3945 (tests/plugin: add a hotblocks plugin) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 ERROR: line over 90 characters #97: FILE: tests/plugin/hotblocks.c:61: + g_string_append_printf(report, " pc: %#" PRIx64 " (%d block%s, %ld insns, %" PRId64" total hits)\n", WARNING: line over 80 characters #99: FILE: tests/plugin/hotblocks.c:63: + rec->trans_count, rec->trans_count < 2 ? "" : "s", WARNING: line over 80 characters #121: FILE: tests/plugin/hotblocks.c:85: + cnt = (ExecCount *) g_hash_table_lookup(hotblocks, (gconstpointer) cheap_hash); WARNING: line over 80 characters #142: FILE: tests/plugin/hotblocks.c:106: + cnt = (ExecCount *) g_hash_table_lookup(hotblocks, (gconstpointer) cheap_hash); total: 1 errors, 4 warnings, 152 lines checked Patch 43/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 44/50 Checking commit 6d4683cf10dc (plugin: add qemu_plugin_insn_disas helper) ERROR: space prohibited between function name and open parenthesis '(' #36: FILE: disas.c:493: +static void plugin_print_address (bfd_vma addr, struct disassemble_info *info) WARNING: line over 80 characters #42: FILE: disas.c:499: +static bool plugin_cap_disas_insn(disassemble_info *info, uint64_t pc, size_t size) ERROR: "foo * bar" should be "foo *bar" #72: FILE: disas.c:529: +char * plugin_disas(CPUState *cpu, uint64_t addr, size_t size) ERROR: braces {} are necessary for all arms of this statement #115: FILE: disas.c:572: + if (count < 0) [...] ERROR: "foo * bar" should be "foo *bar" #135: FILE: include/disas/disas.h:16: +char * plugin_disas(CPUState *cpu, uint64_t addr, size_t size); ERROR: "foo * bar" should be "foo *bar" #154: FILE: include/qemu/qemu-plugin.h:322: +char * qemu_plugin_insn_disas(const struct qemu_plugin_insn *insn); total: 5 errors, 1 warnings, 158 lines checked Patch 44/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 45/50 Checking commit d1f355eb9db4 (tests/plugin: add instruction execution breakdown) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 ERROR: space required after that ',' (ctx:VxV) #99: FILE: tests/plugin/howvec.c:69: + { " Add/Sub (imm,tags)","asit", 0x1f800000, 0x11800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #122: FILE: tests/plugin/howvec.c:92: + { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #122: FILE: tests/plugin/howvec.c:92: + { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #124: FILE: tests/plugin/howvec.c:94: + { " AdvSimd ldst++", "advlssp",0xbf800000, 0x0d800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #128: FILE: tests/plugin/howvec.c:98: + { " ldst noalloc pair", "ldstnap",0x3b800000, 0x28000000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #132: FILE: tests/plugin/howvec.c:102: + { " ldst reg (reg off)","ldstro", 0x3b200b00, 0x38200800, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #161: FILE: tests/plugin/howvec.c:131: + g_string_append_printf(report,"Class: %-24s\t(%ld hits)\n", ^ WARNING: line over 80 characters #162: FILE: tests/plugin/howvec.c:132: + insn_classes[i].class, insn_classes[i].count); WARNING: line over 80 characters #166: FILE: tests/plugin/howvec.c:136: + g_string_append_printf(report,"Class: %-24s\tcounted individually\n", ERROR: space required after that ',' (ctx:VxV) #166: FILE: tests/plugin/howvec.c:136: + g_string_append_printf(report,"Class: %-24s\tcounted individually\n", ^ ERROR: space required after that ',' (ctx:VxV) #170: FILE: tests/plugin/howvec.c:140: + g_string_append_printf(report,"Class: %-24s\tnot counted\n", ^ ERROR: space required after that ',' (ctx:VxV) #182: FILE: tests/plugin/howvec.c:152: + g_string_append_printf(report,"Individual Instructions:\n"); ^ WARNING: line over 80 characters #188: FILE: tests/plugin/howvec.c:158: + g_string_append_printf(report, "Instr: %-24s\t(%ld hits)\t(op=%#08x/%s)\n", WARNING: line over 80 characters #192: FILE: tests/plugin/howvec.c:162: + rec->class ? rec->class->class : "un-categorised"); ERROR: "foo * bar" should be "foo *bar" #212: FILE: tests/plugin/howvec.c:182: +static uint64_t * find_counter(struct qemu_plugin_insn *insn) WARNING: line over 80 characters #243: FILE: tests/plugin/howvec.c:213: + icount = (InsnExecCount *) g_hash_table_lookup(insns, GUINT_TO_POINTER(opcode)); ERROR: line over 90 characters #252: FILE: tests/plugin/howvec.c:222: + dprintf(stdout_fd, "adding instrumentation for %s (%#08x @ %#20lx from %s)\n", WARNING: line over 80 characters #253: FILE: tests/plugin/howvec.c:223: + icount->insn, opcode, qemu_plugin_insn_vaddr(insn), class->class); WARNING: line over 80 characters #255: FILE: tests/plugin/howvec.c:225: + g_hash_table_insert(insns, GUINT_TO_POINTER(opcode), (gpointer) icount); total: 12 errors, 8 warnings, 304 lines checked Patch 45/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 46/50 Checking commit df9793f9866c (tests/plugin: add hotpages plugin to breakdown memory access patterns) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 ERROR: space required after that ',' (ctx:VxV) #88: FILE: tests/plugin/hotpages.c:59: + g_string_append_printf(report,"Individual Instructions:\n"); ^ ERROR: line over 90 characters #94: FILE: tests/plugin/hotpages.c:65: + g_string_append_printf(report, "Page: %"PRIx64" cpus:%#04x/%#04x %"PRId64"/%"PRId64"\n", ERROR: that open brace { should be on the previous line #152: FILE: tests/plugin/hotpages.c:123: +static GOptionEntry entries[] = +{ WARNING: line over 80 characters #154: FILE: tests/plugin/hotpages.c:125: + { "inline", 'i', 0, G_OPTION_ARG_NONE, &do_inline, "Inline counters", NULL }, ERROR: space prohibited between function name and open parenthesis '(' #164: FILE: tests/plugin/hotpages.c:135: + context = g_option_context_new ("- hot pages tool"); ERROR: space prohibited between function name and open parenthesis '(' #165: FILE: tests/plugin/hotpages.c:136: + g_option_context_add_main_entries (context, entries, NULL); ERROR: that open brace { should be on the previous line #166: FILE: tests/plugin/hotpages.c:137: + if (!g_option_context_parse (context, &argc, &argv, &error)) + { ERROR: space prohibited between function name and open parenthesis '(' #166: FILE: tests/plugin/hotpages.c:137: + if (!g_option_context_parse (context, &argc, &argv, &error)) total: 7 errors, 2 warnings, 159 lines checked Patch 46/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 47/50 Checking commit 9ba123bb95e6 (accel/stubs: reduce headers from tcg-stub) 48/50 Checking commit f5a1e5b54136 (include/exec: wrap cpu_ldst.h in CONFIG_TCG) 49/50 Checking commit ed124e922b01 (include/exec/cpu-defs.h: fix typo) 50/50 Checking commit 049048fdb87a (TODO: API changes to make?) ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 7 lines checked Patch 50/50 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190614171200.21078-1-alex.ben...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com