On 20.06.19 19:09, Max Reitz wrote: > On 20.06.19 03:03, John Snow wrote: >> Because the new-style python tests don't use the iotests.main() test >> launcher, we don't turn on the debugger logging for these scripts >> when invoked via ./check -d. >> >> Refactor the launcher shim into new and old style shims so that they >> share environmental configuration. >> >> Two cleanup notes: debug was not actually used as a global, and there >> was no reason to create a class in an inner scope just to achieve >> default variables; we can simply create an instance of the runner with >> the values we want instead. >> >> Signed-off-by: John Snow <js...@redhat.com> >> --- >> tests/qemu-iotests/iotests.py | 40 +++++++++++++++++++++++------------ >> 1 file changed, 26 insertions(+), 14 deletions(-) > > I don’t quite get how script_main() works (yes, both my Pythonfu and my > Googlefu are that bad), but it works and looks good, so have a
Oh, it doesn’t work (well, not automagically). I just assumed seeing the log output means it’s working. Seeing that the test needs to call iotests.script_main() explicitly does clear up my confusion. All OK with me. Max
signature.asc
Description: OpenPGP digital signature
