20.06.2019 19:47, Max Reitz wrote: > On 20.06.19 03:03, John Snow wrote: >> Signed-off-by: John Snow <js...@redhat.com> >> --- >> util/hbitmap.c | 22 +++++++++++++++++++++- >> 1 file changed, 21 insertions(+), 1 deletion(-) > > I wonder whether this could be used in > backup_incremental_init_copy_bitmap(). The sync_bitmap must have the > same length as the source BDS, right? >
A little problem here is that in backup code we merge BdrvDirtyBitmap into HBitmap, so hbitmap API can't be directly used here, and to avoid code duplication we need to create a bit strange interface of merging exactly BdrvDirtyBitmap into HBitmap.. But, anyway it's better than code duplication. Yes, they should have the same length. But we may allow at least merging smaller bitmap into larger, why not? -- Best regards, Vladimir
