> On 22 Jun 2019, at 18:27, Kevin O'Connor <ke...@koconnor.net> wrote: > > On Sat, Jun 22, 2019 at 11:51:48AM +0300, Sam Eiderman wrote: >> But maybe someone wants bootorder but doesn’t want to override legacy disk >> translations… >> >> I’m thinking of maybe adding >> >> if (!CONFIG_BOOTORDER || !CONFIG_BIOS_GEOMETRY) >> return NULL; > > That's fine - though it's (!CONFIG_BOOTORDER && !CONFIG_BIOS_GEOMETRY). Yes of course, my bad > > FYI, I think BIOS_GEOMETRY is a little confusing - maybe > CUSTOM_DISK_GEOMETRY. The thing is that disk geometry is actually (physical geometry, reported by the disk controller) and here bios geometry stands for the geometry reported from bios int13. Also “bios geometry” === “logical geometry” === “lchs”. So following previous discussion with Gerd, maybe CONFIG_HOST_BIOS_GEOMETRY is better? Sam > > -Kevin
- [Qemu-devel] [SeaBIOS] [PATCH v3 0/4] Add Qemu to SeaBIOS L... Sam Eiderman
- [Qemu-devel] [SeaBIOS] [PATCH v3 1/4] geometry: Read L... Sam Eiderman
- [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry: Add bo... Sam Eiderman
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geometry... Kevin O'Connor
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] geom... Sam Eiderman
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 3/4] ... Kevin O'Connor
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 ... Sam Eiderman
- Re: [Qemu-devel] [SeaBIOS] [PATCH... Kevin O'Connor
- Re: [Qemu-devel] [SeaBIOS] [P... Sam Eiderman
- Re: [Qemu-devel] [SeaBIOS] [P... Sam Eiderman
- [Qemu-devel] [SeaBIOS] [PATCH v3 2/4] boot: Reorder fu... Sam Eiderman
- [Qemu-devel] [SeaBIOS] [PATCH v3 4/4] geometry: Apply ... Sam Eiderman
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 4/4] geometry... Gerd Hoffmann
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 4/4] geom... Sam Eiderman
- Re: [Qemu-devel] [SeaBIOS] [PATCH v3 4/4] ... Gerd Hoffmann