On 6/16/19 4:36 PM, Michael S. Tsirkin wrote:
> From: Marc-André Lureau <marcandre.lur...@redhat.com>
>
> This check shouldn't be necessary, since &error_fatal is given as
> argument and will exit() on failure. However, this change should
> silence coverity CID 1401761 & 1401705.
>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> Message-Id: <20190605145829.7674-3-marcandre.lur...@redhat.com>
> Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
> Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> contrib/vhost-user-gpu/main.c | 4 ++++
> contrib/vhost-user-input/main.c | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/contrib/vhost-user-gpu/main.c b/contrib/vhost-user-gpu/main.c
> index 9614c9422c..e0b6df5b4d 100644
> --- a/contrib/vhost-user-gpu/main.c
> +++ b/contrib/vhost-user-gpu/main.c
> @@ -1160,6 +1160,10 @@ main(int argc, char *argv[])
>
> if (opt_socket_path) {
> int lsock = unix_listen(opt_socket_path, &error_fatal);
> + if (lsock < 0) {
> + g_printerr("Failed to listen on %s.\n", opt_socket_path);
> + exit(EXIT_FAILURE);
> + }4 lines to appease Coverity; wouldn't the following one-liner also do the trick? int lsock = unix_listen(opt_socket_path, &error_fatal); assert (lsock >= 0); -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
