On 6/26/19 4:53 PM, John Snow wrote: > Reported-by: radmehrsae...@gmail.com > Fixes: https://bugs.launchpad.net/bugs/1832914 > Signed-off-by: John Snow <js...@redhat.com> > --- > block/qcow.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-)
Yes, this is useful. Reviewed-by: Eric Blake <ebl...@redhat.com> Reminds me of when I helped convince the file(1) database maintainers that 'qcow2 (v3)' was better than 'qcow (v3)'. (https://bugzilla.redhat.com/show_bug.cgi?id=1654349, file.git 60b896d4) > > diff --git a/block/qcow.c b/block/qcow.c > index 6dee5bb792..a9cb6ae0bd 100644 > --- a/block/qcow.c > +++ b/block/qcow.c > @@ -156,7 +156,12 @@ static int qcow_open(BlockDriverState *bs, QDict > *options, int flags, > goto fail; > } > if (header.version != QCOW_VERSION) { > - error_setg(errp, "Unsupported qcow version %" PRIu32, > header.version); > + error_setg(errp, "qcow (v%d) does not support qcow version %" PRIu32, > + QCOW_VERSION, header.version); > + if (header.version == 2 || header.version == 3) { > + error_append_hint(errp, "Try the 'qcow2' driver instead."); > + } > + > ret = -ENOTSUP; > goto fail; > } > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
