On Mon, Jun 10, 2019 at 01:14:57PM +0200, Paolo Bonzini wrote: > The Meson build system is integrated in the existing configure/make steps > by invoking Meson from the configure script and converting Meson's build.ninja > rules to an included Makefile.
Why did you take the route of converting ninja rules into makefile rules, as opposed to just having some stub makefile rules which directly invoke ninja where needed ? Obviously this series is just some initial integration, but eventually when we get a complete conversion, I think it will look pretty wierd if we're still converting ninja to make. Part of the downside of our current build system is that although it uses make, the usage is wierd and QEMU specific structure. It would be a shame to pick meson and then again use it is a way that is wierd and QEMU specific. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|