On Thu, Jun 27, 2019 at 1:31 PM Philippe Mathieu-Daudé
<phi...@redhat.com> wrote:
>
> Signed-off-by: Stephen Checkoway <stephen.checko...@oberlin.edu>
> Message-Id: <20190426162624.55977-3-stephen.checko...@oberlin.edu>
> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> [PMD: Extracted from bigger patch]
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com>
Alistair
> ---
> hw/block/pflash_cfi02.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> index e9eea0ec08..9e8c28af8f 100644
> --- a/hw/block/pflash_cfi02.c
> +++ b/hw/block/pflash_cfi02.c
> @@ -239,10 +239,10 @@ static uint32_t pflash_read(PFlashCFI02 *pfl, hwaddr
> offset,
> case 0x0E:
> case 0x0F:
> ret = boff & 0x01 ? pfl->ident3 : pfl->ident2;
> - if (ret == (uint8_t)-1) {
> - goto flash_read;
> + if (ret != (uint8_t)-1) {
> + break;
> }
> - break;
> + /* Fall through to data read. */
> default:
> goto flash_read;
> }
> --
> 2.20.1
>
>
