On Mon, 2019-07-01 at 19:13 +0100, Peter Maydell wrote: > On Mon, 1 Jul 2019 at 19:09, Alistair Francis < > alistair.fran...@wdc.com> wrote: > > On Mon, 2019-07-01 at 19:01 +0100, Peter Maydell wrote: > > > On Mon, 1 Jul 2019 at 18:50, Alistair Francis < > > > alistair.fran...@wdc.com> wrote: > > > > PS: It seems like there are still some issues with this patch > > > > so > > > > maybe > > > > it's worth dropping this patch from the PR so that we can get > > > > everything else merged. > > > > > > Yeah, that would be my suggestion. > > > > Can you do that when you merge it or does Palmer have to send the > > PR > > again? > > Palmer needs to respin it -- pulls are signed and I can't > modify them, only either apply them or not. (Technically I > could in theory cherry-pick all the other commits out of them > but that would be a huge amount of manual labour.)
No worries. @Palmer can you please drop these two patches from this PR? hw/riscv: Load OpenSBI as the default firmware roms: Add OpenSBI version 0.3 Sorry for the all the last minute changes. I'll wait until OpenSBI 0.4 to respin those two patches. Alistair > > thanks > -- PMM