Patchew URL: https://patchew.org/QEMU/20190702060857.3926-1-da...@gibson.dropbear.id.au/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190702060857.3926-1-da...@gibson.dropbear.id.au Subject: [Qemu-devel] [PULL 00/49] ppc-for-4.1 queue 20190702 === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 7bb3b05 spapr/xive: Add proper rollback to kvmppc_xive_connect() 74a4495 ppc/xive: Fix TM_PULL_POOL_CTX special operation 1404e29 ppc/pnv: Rework cache watch model of PnvXIVE 9cca994 ppc/xive: Make the PIPR register readonly bcfb6f6 ppc/xive: Force the Physical CAM line value to group mode 787ce6b spapr/xive: simplify spapr_irq_init_device() to remove the emulated init 458f034 spapr/xive: rework the mapping the KVM memory regions eae9058 spapr_pci: Unregister listeners before destroying the IOMMU address space e0180a6 target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro f733daa target/ppc: decode target register in VSX_EXTRACT_INSERT at translation time 801aa3c target/ppc: decode target register in VSX_VECTOR_LOAD_STORE_LENGTH at translation time d395162 target/ppc: introduce GEN_VSX_HELPER_R2_AB macro to fpu_helper.c c29f61e target/ppc: introduce GEN_VSX_HELPER_R2 macro to fpu_helper.c ae3729a target/ppc: introduce GEN_VSX_HELPER_R3 macro to fpu_helper.c 1ee4cc9 target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c 02b5b37 target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c 2e9690e target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c 07164a1 target/ppc: introduce separate generator and helper for xscvqpdp 4b9b416 target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c 75e73ee target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions a90073b target/ppc: remove getVSR()/putVSR() from int_helper.c 79c670e target/ppc/machine: Add kvmppc_pvr_workaround_required() stub 37ad392 ppc: Introduce kvmppc_set_reg_tb_offset() helper 17d30b4 xics/kvm: Add proper rollback to xics_kvm_init() 1a00629 xics/kvm: Add error propagation to ic*_set_kvm_state() functions 7c2ec89 xics/kvm: Always use local_err in xics_kvm_init() 4cc5946 xics/kvm: Skip rollback when KVM XICS is absent 85863d0 xics/spapr: Rename xics_kvm_init() 74cf682 xics/spapr: Drop unused function declaration 9181bd9 hw/ppc: Drop useless CONFIG_KVM ifdefery de2ce93 hw/ppc/prep: Drop useless CONFIG_KVM ifdefery 303565a hw/ppc/mac_newworld: Drop useless CONFIG_KVM ifdefery 4a1015b hw/ppc/mac_oldworld: Drop useless CONFIG_KVM ifdefery aedda48 spapr_pci: Drop useless CONFIG_KVM ifdefery e84716e xics/spapr: Only emulated XICS should use RTAS/hypercalls emulation ccb81cd spapr_pci: Fix DRC owner in spapr_dt_pci_bus() ce58656 target/ppc: remove getVSR()/putVSR() from mem_helper.c 14377ef target/ppc: remove getVSR()/putVSR() from fpu_helper.c 783df71 xics: Add comment about CPU hotplug 0b77fd8 target/ppc: fix compile error in kvmppc_define_rtas_kernel_token() d62dc63 xics/spapr: Detect old KVM XICS on POWER9 hosts 7cad8aa xics/spapr: Register RTAS/hypercalls once at machine init ae97fbe xics/spapr: Prevent RTAS/hypercalls emulation to be used by in-kernel XICS c8ed9dc spapr_pci: Fix potential NULL pointer dereference in spapr_dt_pci_bus() 65aa189 ppc/pnv: remove xscom_base field from PnvChip 9a78f90 ppc/pnv: fix XSCOM MMIO base address for P9 machines with multiple chips e5ccb2b ppc/pnv: fix StoreEOI activation 4d94a5e docs: updates on the POWER9 XIVE interrupt controller documentation 570deae spapr/rtas: Force big endian compile for rtas === OUTPUT BEGIN === 1/49 Checking commit 570deaec62c6 (spapr/rtas: Force big endian compile for rtas) 2/49 Checking commit 4d94a5eb7097 (docs: updates on the POWER9 XIVE interrupt controller documentation) 3/49 Checking commit e5ccb2b1ebc9 (ppc/pnv: fix StoreEOI activation) 4/49 Checking commit 9a78f90b675a (ppc/pnv: fix XSCOM MMIO base address for P9 machines with multiple chips) 5/49 Checking commit 65aa189992d2 (ppc/pnv: remove xscom_base field from PnvChip) 6/49 Checking commit c8ed9dca1c3c (spapr_pci: Fix potential NULL pointer dereference in spapr_dt_pci_bus()) 7/49 Checking commit ae97fbe5c3f9 (xics/spapr: Prevent RTAS/hypercalls emulation to be used by in-kernel XICS) 8/49 Checking commit 7cad8aa1b137 (xics/spapr: Register RTAS/hypercalls once at machine init) 9/49 Checking commit d62dc6330674 (xics/spapr: Detect old KVM XICS on POWER9 hosts) WARNING: line over 80 characters #97: FILE: hw/ppc/spapr_irq.c:682: + error_setg(errp, "KVM is too old to support ic-mode=dual,kernel-irqchip=on"); total: 0 errors, 1 warnings, 69 lines checked Patch 9/49 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/49 Checking commit 0b77fd89962f (target/ppc: fix compile error in kvmppc_define_rtas_kernel_token()) 11/49 Checking commit 783df71d0b62 (xics: Add comment about CPU hotplug) 12/49 Checking commit 14377efcbff8 (target/ppc: remove getVSR()/putVSR() from fpu_helper.c) 13/49 Checking commit ce586560d56d (target/ppc: remove getVSR()/putVSR() from mem_helper.c) 14/49 Checking commit ccb81cd0bad6 (spapr_pci: Fix DRC owner in spapr_dt_pci_bus()) 15/49 Checking commit e84716e57bee (xics/spapr: Only emulated XICS should use RTAS/hypercalls emulation) 16/49 Checking commit aedda482919a (spapr_pci: Drop useless CONFIG_KVM ifdefery) 17/49 Checking commit 4a1015bcf595 (hw/ppc/mac_oldworld: Drop useless CONFIG_KVM ifdefery) 18/49 Checking commit 303565a0b711 (hw/ppc/mac_newworld: Drop useless CONFIG_KVM ifdefery) 19/49 Checking commit de2ce93dba0b (hw/ppc/prep: Drop useless CONFIG_KVM ifdefery) 20/49 Checking commit 9181bd9b16f9 (hw/ppc: Drop useless CONFIG_KVM ifdefery) 21/49 Checking commit 74cf68259256 (xics/spapr: Drop unused function declaration) 22/49 Checking commit 85863d031010 (xics/spapr: Rename xics_kvm_init()) 23/49 Checking commit 4cc5946f0e91 (xics/kvm: Skip rollback when KVM XICS is absent) 24/49 Checking commit 7c2ec89ce076 (xics/kvm: Always use local_err in xics_kvm_init()) WARNING: line over 80 characters #63: FILE: hw/intc/xics_kvm.c:385: + error_setg_errno(&local_err, -rc, "Error on KVM_CREATE_DEVICE for XICS"); total: 0 errors, 1 warnings, 55 lines checked Patch 24/49 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/49 Checking commit 1a0062929560 (xics/kvm: Add error propagation to ic*_set_kvm_state() functions) 26/49 Checking commit 17d30b4f69ab (xics/kvm: Add proper rollback to xics_kvm_init()) 27/49 Checking commit 37ad392fb139 (ppc: Introduce kvmppc_set_reg_tb_offset() helper) 28/49 Checking commit 79c670e7e713 (target/ppc/machine: Add kvmppc_pvr_workaround_required() stub) 29/49 Checking commit a90073b0510e (target/ppc: remove getVSR()/putVSR() from int_helper.c) 30/49 Checking commit 75e73ee1fe0f (target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions) 31/49 Checking commit 4b9b4167f9fa (target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c) 32/49 Checking commit 07164a184b28 (target/ppc: introduce separate generator and helper for xscvqpdp) 33/49 Checking commit 2e9690eca58f (target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c) 34/49 Checking commit 02b5b37dc7bd (target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c) 35/49 Checking commit 1ee4cc900275 (target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c) 36/49 Checking commit ae3729a09288 (target/ppc: introduce GEN_VSX_HELPER_R3 macro to fpu_helper.c) 37/49 Checking commit c29f61e4ae3a (target/ppc: introduce GEN_VSX_HELPER_R2 macro to fpu_helper.c) 38/49 Checking commit d395162f195d (target/ppc: introduce GEN_VSX_HELPER_R2_AB macro to fpu_helper.c) 39/49 Checking commit 801aa3c44b5a (target/ppc: decode target register in VSX_VECTOR_LOAD_STORE_LENGTH at translation time) 40/49 Checking commit f733daaa8fd5 (target/ppc: decode target register in VSX_EXTRACT_INSERT at translation time) 41/49 Checking commit e0180a6c3764 (target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro) WARNING: Block comments use a leading /* on a separate line #281: FILE: target/ppc/translate/vsx-impl.inc.c:1312: + /* \ WARNING: Block comments use a leading /* on a separate line #287: FILE: target/ppc/translate/vsx-impl.inc.c:1318: + /* \ ERROR: Macros with complex values should be enclosed in parenthesis #328: FILE: target/ppc/translate/vsx-ops.inc.c:66: +#define GEN_XX3FORM_NAME(name, opcname, opc2, opc3, fl2) \ +GEN_HANDLER2_E(name, opcname, 0x3C, opc2 | 0, opc3, 0, PPC_NONE, fl2), \ +GEN_HANDLER2_E(name, opcname, 0x3C, opc2 | 1, opc3, 0, PPC_NONE, fl2), \ +GEN_HANDLER2_E(name, opcname, 0x3C, opc2 | 2, opc3, 0, PPC_NONE, fl2), \ +GEN_HANDLER2_E(name, opcname, 0x3C, opc2 | 3, opc3, 0, PPC_NONE, fl2) total: 1 errors, 2 warnings, 377 lines checked Patch 41/49 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 42/49 Checking commit eae905822666 (spapr_pci: Unregister listeners before destroying the IOMMU address space) 43/49 Checking commit 458f0347832b (spapr/xive: rework the mapping the KVM memory regions) 44/49 Checking commit 787ce6b4e3b4 (spapr/xive: simplify spapr_irq_init_device() to remove the emulated init) 45/49 Checking commit bcfb6f654a74 (ppc/xive: Force the Physical CAM line value to group mode) 46/49 Checking commit 9cca99465fba (ppc/xive: Make the PIPR register readonly) 47/49 Checking commit 1404e29c7310 (ppc/pnv: Rework cache watch model of PnvXIVE) 48/49 Checking commit 74a4495d9161 (ppc/xive: Fix TM_PULL_POOL_CTX special operation) 49/49 Checking commit 7bb3b05d7b5f (spapr/xive: Add proper rollback to kvmppc_xive_connect()) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190702060857.3926-1-da...@gibson.dropbear.id.au/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
