Patchew URL: https://patchew.org/QEMU/20190705072333.17171-1-kl...@birkelund.eu/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 00/16] nvme: support NVMe v1.3d, SGLs and multiple namespaces Message-id: 20190705072333.17171-1-kl...@birkelund.eu === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' aed82e6 nvme: support multiple namespaces 124aba5 nvme: support scatter gather lists 87ed485 nvme: support multiple block requests per request a093729 nvme: simplify dma/cmb mappings 476911f nvme: bump supported NVMe revision to 1.3d 5856e28 nvme: add missing mandatory Features c1555e1 nvme: support Get Log Page command 36411fc nvme: support Asynchronous Event Request command c27295f nvme: refactor device realization 9b85297 nvme: support Abort command b4752ee nvme: support completion queue in cmb cecb502 nvme: populate the mandatory subnqn and ver fields 01283a3 nvme: add missing fields in identify controller c8dcb3f nvme: fix lpa field 4515446 nvme: move device parameters to separate struct 9f1a140 nvme: simplify namespace code === OUTPUT BEGIN === 1/16 Checking commit 9f1a1408cc38 (nvme: simplify namespace code) 2/16 Checking commit 451544667fc8 (nvme: move device parameters to separate struct) ERROR: Macros with complex values should be enclosed in parenthesis #204: FILE: hw/block/nvme.h:6: +#define DEFINE_NVME_PROPERTIES(_state, _props) \ + DEFINE_PROP_STRING("serial", _state, _props.serial), \ + DEFINE_PROP_UINT32("cmb_size_mb", _state, _props.cmb_size_mb, 0), \ + DEFINE_PROP_UINT32("num_queues", _state, _props.num_queues, 64) total: 1 errors, 0 warnings, 205 lines checked Patch 2/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/16 Checking commit c8dcb3f63fb7 (nvme: fix lpa field) 4/16 Checking commit 01283a3975d7 (nvme: add missing fields in identify controller) 5/16 Checking commit cecb50298f9f (nvme: populate the mandatory subnqn and ver fields) 6/16 Checking commit b4752eecf9e1 (nvme: support completion queue in cmb) 7/16 Checking commit 9b8529736294 (nvme: support Abort command) 8/16 Checking commit c27295f1ea55 (nvme: refactor device realization) 9/16 Checking commit 36411fcd1a67 (nvme: support Asynchronous Event Request command) 10/16 Checking commit c1555e1835da (nvme: support Get Log Page command) 11/16 Checking commit 5856e2876e3c (nvme: add missing mandatory Features) 12/16 Checking commit 476911f6ca42 (nvme: bump supported NVMe revision to 1.3d) 13/16 Checking commit a093729af080 (nvme: simplify dma/cmb mappings) 14/16 Checking commit 87ed48569f6f (nvme: support multiple block requests per request) 15/16 Checking commit 124aba558277 (nvme: support scatter gather lists) 16/16 Checking commit aed82e6e8f62 (nvme: support multiple namespaces) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 631 lines checked Patch 16/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190705072333.17171-1-kl...@birkelund.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com