On 12.07.19 09:35, Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > > Signed-off-by: Pankaj Gupta <pagu...@redhat.com> > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c > index 8b2d0dbccc..0da6627469 100644 > --- a/hw/virtio/virtio-pmem-pci.c > +++ b/hw/virtio/virtio-pmem-pci.c > @@ -57,7 +57,7 @@ static uint64_t virtio_pmem_pci_get_plugged_size(const > MemoryDeviceState *md, > MemoryRegion *mr = vpc->get_memory_region(pmem, errp); > > /* the plugged size corresponds to the region size */ > - return mr ? 0 : memory_region_size(mr); > + return mr ? memory_region_size(mr) : 0; > } > > static void virtio_pmem_pci_fill_device_info(const MemoryDeviceState *md, >
Reviewed-by: David Hildenbrand <da...@redhat.com> -- Thanks, David / dhildenb
