On Wed, Jul 17, 2019 at 11:16:19AM +0200, Paolo Bonzini wrote: >On 17/07/19 03:13, Wei Yang wrote: >> On Tue, May 14, 2019 at 03:21:08PM +0100, Dr. David Alan Gilbert wrote: >>> * Wei Yang (richardw.y...@linux.intel.com) wrote: >>>> Since start of cpu_physical_memory_sync_dirty_bitmap is always 0, we can >>>> remove this parameter and simplify the calculation a bit. >>>> >>>> Signed-off-by: Wei Yang <richardw.y...@linux.intel.com> >>> >>> So I think you're right it's currently unused; however, lets ask >>> Paolo: Do we need to keep this parameter for flexiblity? >>> >> >> Hey, Paolo >> >> Do you have some spare time to give some insight? > >I think it's cleaner to leave the start argument in place. However, >I'll note that in migration_bitmap_sync_range the length argument is >always block->used_length so that's also unnecessary (you already have >block). >
That's reasonable. >Paolo > -- Wei Yang Help you, Help me
