On Thu, 18 Jul 2019 at 10:27, Zhang Chen <chen.zh...@intel.com> wrote: > > From: Zhang Chen <chen.zh...@intel.com> > > This patch to fix the origin "char *data" menory leak, code style issue > and add necessary check here. > Reported-by: Coverity (CID 1402785) > > Signed-off-by: Zhang Chen <chen.zh...@intel.com> > --- > net/colo-compare.c | 28 +++++++++++++++++++++------- > 1 file changed, 21 insertions(+), 7 deletions(-) > > diff --git a/net/colo-compare.c b/net/colo-compare.c > index 909dd6c6eb..fcccb4c6f6 100644 > --- a/net/colo-compare.c > +++ b/net/colo-compare.c > @@ -127,6 +127,17 @@ static int compare_chr_send(CompareState *s, > uint32_t vnet_hdr_len, > bool notify_remote_frame); > > +static bool packet_matches_str(const char *str, > + uint8_t *buf, > + uint32_t packet_len) > +{ > + if (packet_len != strlen(str)) {
Is '!=' definitely correct? (ie the incoming packet must *not* contain a trailing '\0' or any other trailing data) ? Is there a specification of the protocol somewhere? If so, that presumably should say one way or the other. > + return false; > + } > + > + return !memcmp(str, buf, strlen(str)); > +} thanks -- PMM