On 6 May 2011 15:09, Paul Brook <p...@codesourcery.com> wrote: >> The Neon versions of int-float conversions need their own helper routines >> because they must use the "standard FPSCR" rather than the default one. >> Refactor the helper functions to make it easy to add the neon versions. >> While we're touching the code, move the helpers to op_helper.c so that >> we can use the global env variable rather than passing it as a parameter. > > IMO this is going in the wrong direction. We should in aiming for less > implicit accesses to cpu state, not more.
I don't have a very strong feeling about this personally, I've just been going in the direction suggested by past discussions eg http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00183.html > Maybe better would be to explicitly pass a pointer the fp status. That way you > don't even need separate VFP and NEON variants of these routines. If you were otherwise going to pass in a CPUState pointer then just passing the pointer to the fp_status is probably better, yes. -- PMM