On 22.07.19 11:44, Liran Alon wrote: > > >> On 22 Jul 2019, at 7:00, Jan Kiszka <jan.kis...@siemens.com> wrote: >> >> Writing the nested state e.g. after a vmport access can invalidate >> important parts of the kernel-internal state, and it is not needed as >> well. So leave this out from KVM_PUT_RUNTIME_STATE. >> >> Suggested-by: Paolo Bonzini <pbonz...@redhat.com> >> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> > > As QEMU never modifies vCPU nested-state in userspace besides in vmload and > vCPU creation, > shouldn’t this be under KVM_PUT_FULL_STATE? Same as the call to > kvm_arch_set_tsc_khz().
Reset is a relevant modification as well. If we do not write back a state that is disabling virtualization, we break. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
