On Fri, 19 Jul 2019 at 11:18, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > > Hi > > On Fri, Jul 19, 2019 at 2:10 PM Peter Maydell <peter.mayd...@linaro.org> > wrote: > > > > contrib/elf2dmp has a source file which uses curl/curl.h; > > although we link the final executable with CURL_LIBS, we > > forgot to build this source file with CURL_CFLAGS, so if > > the curl header is in a place that's not already on the > > system include path then it will fail to build. > > > > Add a line specifying the cflags needed for download.o; > > while we are here, bring the specification of the libs > > into line with this, since using a per-object variable > > setting is preferred over adding them to the final > > executable link line. > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
Thanks. Since we don't have an obvious route for elf2dmp patches to go into master I'll just put this in via the arm pullreq I'm putting together for rc2. -- PMM