On Mon, 22 Jul 2019 at 13:33, Michael Rolnik <mrol...@gmail.com> wrote: > I changed it to info_report. > raw binaries are totally fine, however if a user supplies a damaged elf he > will never know if no warning/info is reported.
I find a good rule of thumb for architecture specific/board specific code is that if other boards/architectures don't do a particular thing, it's usually better to be consistent with the rest of QEMU, rather than introducing an innovation. "Try to load as an ELF file; if that didn't work fall back to loading as a raw image" is what other parts of QEMU do, and they don't complain about doing it. Otherwise, every user of raw images gets a spurious complaint that their raw image isn't an ELF file... thanks -- PMM
