Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

[Stefan Hajnoczi]

On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote:
> -            snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s",
> -                     helper, "--use-vnet", fd_buf, br_buf);
> +            helper_cmd = g_strdup_printf("%s %s %s %s", helper,
> +                            "--use-vnet", fd_buf, br_buf ? br_buf : "");

The change to the br_buf argument isn't covered in the commit
description.  Why did you change this, was it a bug, etc?

signature.asc
Description: PGP signature