On 7/24/19 11:23 PM, Oleinik, Alexander wrote: > Signed-off-by: Alexander Oleinik <alx...@bu.edu> Is there some explanation for why the below patch does what the subject line claims for the uninitiated? I don't know why increasing the number of queues from 2 to 3 here is correct in the general case, OR why it would "add ctrl vq support". (Or what it has to do with fuzzing, in general.) [Only responding because this landed in tests/libqos, which I do try to keep an eye on, but this patch is opaque to me. --js] > --- > tests/libqos/virtio-net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/libqos/virtio-net.c b/tests/libqos/virtio-net.c > index 66405b646e..247a0a17a8 100644 > --- a/tests/libqos/virtio-net.c > +++ b/tests/libqos/virtio-net.c > @@ -51,7 +51,7 @@ static void virtio_net_setup(QVirtioNet *interface) > if (features & (1u << VIRTIO_NET_F_MQ)) { > interface->n_queues = qvirtio_config_readw(vdev, 8) * 2; > } else { > - interface->n_queues = 2; > + interface->n_queues = 3; > } > > interface->queues = g_new(QVirtQueue *, interface->n_queues); >
- Re: [Qemu-devel] [RFC 10/19] fuzz: expose rea... Paolo Bonzini
- [Qemu-devel] [RFC 11/19] fuzz: add direct send/rec... Oleinik, Alexander
- Re: [Qemu-devel] [RFC 11/19] fuzz: add direct... Thomas Huth
- [Qemu-devel] [RFC 08/19] fuzz: add shims to interc... Oleinik, Alexander
- Re: [Qemu-devel] [RFC 08/19] fuzz: add shims ... Paolo Bonzini
- Re: [Qemu-devel] [RFC 08/19] fuzz: add sh... Stefan Hajnoczi
- [Qemu-devel] [RFC 15/19] fuzz: add fuzz accelerato... Oleinik, Alexander
- [Qemu-devel] [RFC 14/19] fuzz: hard-code a main-lo... Oleinik, Alexander
- Re: [Qemu-devel] [RFC 14/19] fuzz: hard-code ... Paolo Bonzini
- [Qemu-devel] [RFC 13/19] fuzz: add ctrl vq support... Oleinik, Alexander
- Re: [Qemu-devel] [RFC 13/19] fuzz: add ctrl v... John Snow
- Re: [Qemu-devel] [RFC 13/19] fuzz: add ct... Oleinik, Alexander
- Re: [Qemu-devel] [RFC 13/19] fuzz: ad... Stefan Hajnoczi
- [Qemu-devel] [RFC 18/19] fuzz: Add virtio-net tx a... Oleinik, Alexander
- [Qemu-devel] [RFC 16/19] fuzz: add general fuzzer ... Oleinik, Alexander
- Re: [Qemu-devel] [RFC 16/19] fuzz: add genera... Philippe Mathieu-Daudé
- [Qemu-devel] [RFC 17/19] fuzz: add general qtest f... Oleinik, Alexander
- [Qemu-devel] [RFC 19/19] fuzz: Add documentation a... Oleinik, Alexander
- Re: [Qemu-devel] [RFC 19/19] fuzz: Add docume... Stefan Hajnoczi
- Re: [Qemu-devel] [RFC 00/19] Add virtual device fu... no-reply
- Re: [Qemu-devel] [RFC 00/19] Add virtual device fu... Stefan Hajnoczi