On Wed, Jul 31, 2019 at 1:10 AM Chih-Min Chao <chihmin.c...@sifive.com> wrote:
>
>
>
> On Wed, Jul 31, 2019 at 2:41 AM Alistair Francis <alistai...@gmail.com> wrote:
>>
>> On Mon, Jul 29, 2019 at 8:19 AM Chih-Min Chao <chihmin.c...@sifive.com>
>> wrote:
>> >
>> >
>> > On Fri, Jul 26, 2019 at 2:56 AM Alistair Francis
>> > <alistair.fran...@wdc.com> wrote:
>> >>
>> >> From: Atish Patra <atish.pa...@wdc.com>
>> >>
>> >> As per the RISC-V spec, Floating Point registers are named as f0..f31
>> >> so lets fix the register names accordingly.
>> >>
>> >> Signed-off-by: Atish Patra <atish.pa...@wdc.com>
>> >> Signed-off-by: Alistair Francis <alistair.fran...@wdc.com>
>> >> ---
>> >> target/riscv/cpu.c | 8 ++++----
>> >> 1 file changed, 4 insertions(+), 4 deletions(-)
>> >>
>> >> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
>> >> index f8d07bd20a..af1e9b7690 100644
>> >> --- a/target/riscv/cpu.c
>> >> +++ b/target/riscv/cpu.c
>> >> @@ -40,10 +40,10 @@ const char * const riscv_int_regnames[] = {
>> >> };
>> >>
>> >> const char * const riscv_fpr_regnames[] = {
>> >> - "ft0", "ft1", "ft2", "ft3", "ft4", "ft5", "ft6", "ft7",
>> >> - "fs0", "fs1", "fa0", "fa1", "fa2", "fa3", "fa4", "fa5",
>> >> - "fa6", "fa7", "fs2", "fs3", "fs4", "fs5", "fs6", "fs7",
>> >> - "fs8", "fs9", "fs10", "fs11", "ft8", "ft9", "ft10", "ft11"
>> >> + "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7",
>> >> + "f8", "f9", "f10", "f11", "f12", "f13", "f14", "f15",
>> >> + "f16", "f17", "f18", "f19", "f20", "f21", "f22", "f23",
>> >> + "f24", "f25", "f26", "f27", "f28", "f29", "f30", "f31"
>> >> };
>> >
>> >
>> > Could you indicate the section of the spec ?
>>
>> Chapter 11: "“F” Standard Extension for Single-Precision
>> Floating-Point, Version 2.2", section 11.1, Figure 11.1 shows f0 -
>> f32.
>>
>> > By chapter 20 of user spec, the patch changes the floating register name
>> > to architecture name but leave the integer register use the ABI name.
>>
>> You mean the Packed-SIMD extension?
>>
>> Alistair
>
>
> I means "Chapter 20RISC-V Assembly Programmer’s Handbook".
> There is an table, "Table 20.1: Assembler mnemonics for RISC-V integer and
> floating-point registers.", describes
> the architecture name and ABI name for integer and floating-point register.
Ah ok. In general I think it makes sense to base the names on the spec
and not other sources.
Alistair
>
> By the way, I reference the riscv-spec-2.2
>
> chihmin
>
>
>>
>> >
>> > chihmin
>> >>
>> >> const char * const riscv_excp_names[] = {
>> >> --
>> >> 2.22.0
>> >>
>> >>
