On Sun, Aug 11, 2019 at 1:11 AM Bin Meng <bmeng...@gmail.com> wrote: > > Currently the PRCI register block size is set to 0x8000, but in fact > 0x1000 is enough, which is also what the manual says. > > Signed-off-by: Bin Meng <bmeng...@gmail.com> > Reviewed-by: Chih-Min Chao <chihmin.c...@sifive.com>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Alistair > --- > > Changes in v3: None > Changes in v2: None > > hw/riscv/sifive_e_prci.c | 2 +- > include/hw/riscv/sifive_e_prci.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/riscv/sifive_e_prci.c b/hw/riscv/sifive_e_prci.c > index c906f11..4cbce48 100644 > --- a/hw/riscv/sifive_e_prci.c > +++ b/hw/riscv/sifive_e_prci.c > @@ -85,7 +85,7 @@ static void sifive_prci_init(Object *obj) > SiFivePRCIState *s = SIFIVE_E_PRCI(obj); > > memory_region_init_io(&s->mmio, obj, &sifive_prci_ops, s, > - TYPE_SIFIVE_E_PRCI, 0x8000); > + TYPE_SIFIVE_E_PRCI, SIFIVE_E_PRCI_REG_SIZE); > sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); > > s->hfrosccfg = (SIFIVE_PRCI_HFROSCCFG_RDY | SIFIVE_PRCI_HFROSCCFG_EN); > diff --git a/include/hw/riscv/sifive_e_prci.h > b/include/hw/riscv/sifive_e_prci.h > index 7932fe7..81e506b 100644 > --- a/include/hw/riscv/sifive_e_prci.h > +++ b/include/hw/riscv/sifive_e_prci.h > @@ -47,6 +47,8 @@ enum { > SIFIVE_PRCI_PLLOUTDIV_DIV1 = (1 << 8) > }; > > +#define SIFIVE_E_PRCI_REG_SIZE 0x1000 > + > #define TYPE_SIFIVE_E_PRCI "riscv.sifive.e.prci" > > #define SIFIVE_E_PRCI(obj) \ > -- > 2.7.4 > >