On 8/12/19 7:23 AM, Markus Armbruster wrote: > In my "build everything" tree, changing migration/qemu-file-types.h > triggers a recompile of some 2600 out of 6600 objects (not counting > tests and objects that don't depend on qemu/osdep.h). > > The culprit is again hw/hw.h, which supposedly includes it for > convenience. > > Include migration/qemu-file-types.h only where it's needed. Touching > it now recompiles less than 200 objects. > > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > include/hw/hw.h | 1 - > include/migration/cpu.h | 1 + > hw/acpi/piix4.c | 1 + > hw/block/virtio-blk.c | 1 + > hw/char/virtio-serial-bus.c | 1 + > hw/display/virtio-gpu.c | 1 + > hw/intc/apic_common.c | 1 + > hw/intc/s390_flic_kvm.c | 1 + > hw/nvram/eeprom93xx.c | 1 + > hw/nvram/fw_cfg.c | 1 + > hw/pci-host/piix.c | 1 + > hw/pci/msix.c | 1 + > hw/pci/pci.c | 1 + > hw/pci/shpc.c | 1 + > hw/ppc/spapr.c | 1 + > hw/s390x/s390-skeys.c | 1 + > hw/s390x/tod.c | 1 + > hw/s390x/virtio-ccw.c | 1 + > hw/scsi/mptsas.c | 1 + > hw/scsi/scsi-bus.c | 1 + > hw/scsi/scsi-disk.c | 1 + > hw/scsi/scsi-generic.c | 1 + > hw/scsi/virtio-scsi.c | 1 + > hw/timer/i8254_common.c | 1 + > hw/timer/twl92230.c | 1 + > hw/usb/redirect.c | 1 + > hw/virtio/vhost.c | 1 + > hw/virtio/virtio-mmio.c | 1 + > hw/virtio/virtio-pci.c | 1 + > hw/virtio/virtio.c | 1 + > target/ppc/kvm.c | 1 + > 31 files changed, 30 insertions(+), 1 deletion(-)