On 8/13/19 2:00 AM, Richard Henderson wrote: > On 8/10/19 5:12 AM, Jan Bobek wrote: >> This header is intended to eventually list all supported instructions >> along with some useful details (e.g. mnemonics, opcode, operands etc.) >> It shall be used (along with some preprocessor magic) anytime we need >> to automatically generate code for every instruction. >> >> Signed-off-by: Jan Bobek <jan.bo...@gmail.com> >> --- >> target/i386/insn.h | 87 ++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 87 insertions(+) >> create mode 100644 target/i386/insn.h > > Things that are included multiple times should be named *.inc.h. There are > quite a few that don't follow this in the tree, but we are slowly fixing > those. > > Though even "insn.inc.h" isn't particularly descriptive, and definitely > overstates the case. Maybe sse-opcode.inc.h? While it's not only sse, it is > used by gen_sse_ng().
"sse-opcode.inc.h" isn't 100 % as you point out, but looks good enough for now. -Jan
signature.asc
Description: OpenPGP digital signature
